Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#6064 closed enhancement (fixed)

Make existing Grunt tasks clearer, and improve the release packaging process.

Reported by: DJPaul Owned by: djpaul
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Cc:

Description

A few times during this and the last release cycle, I've noticed that we've forgotten to run the pre-commit Grunt task. I also remember some confusion for one of the recent minor releases (I think); we thought "build-release" would produce a version of BuddyPress ready to be added to our distribution SVN -- but it doesn't (it includes a copy of bbPress 1, which we set up as a svn:external in our distribution SVN).

I'm going to commit two changes to the Grunt tasks:

1) Rename the build-* tasks to something shorter and more descriptive of what it affects.
2) Add a new task that produces a version of BuddyPress ready to go into our distribution SVN.

Making the build processes easier to understand and more helpful is something I think we have to continue iterating on, but I think these few simple renames will make things clearer, especially for new contributors to the project. And anything that saves us work when we do a release is a win, too.

Attachments (1)

6064.1.diff (879 bytes) - added by netweb 6 years ago.

Download all attachments as: .zip

Change History (6)

#1 @djpaul
6 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 9229:

Grunt: rename the build-* tasks and add new task to help package releases.

Clarifying the existing build-* tasks will help reduce confusion for contributors to the project by making it easier to understand when each should be run.
A new task to help the BuddyPress team package new releases will help make our release process more straightforward and hopefully save time.

The Grunt tasks are now:

  • "src" -- operates on the src/ folder. To be run during development.
  • "commit" -- operates on the src/ folder. To be run before commit.
  • "build" -- updates the build/ folder. Creates a build of BuddyPress ready for full testing (with minified assets, etc).
  • "release" -- updates the build/ folder. Creates the release version of BuddyPress, ready to be added to our distribution SVN.

In the near future, we'll probably add a grunt watch task which will do the same thing as the new src task.

Fixes #6064

@netweb
6 years ago

#2 @netweb
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to have the Grunt tasks perform what the tasks descriptions in r9229 documents

  • "build" -- updates the build/ folder. Creates a build of BuddyPress ready for full testing (with minified assets, etc).
  • "release" -- updates the build/ folder. Creates the release version of BuddyPress, ready to be added to our distribution SVN.

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


6 years ago

#4 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 9427:

Grunt build and release tasks were reversed. Props netweb. Fixes #6064.

#5 @DJPaul
4 years ago

  • Component changed from Tools - Build Process to Build/Test Tools
Note: See TracTickets for help on using tickets.