Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

#606 closed enhancement (fixed)

Many places where $bp->root_domain is more appropriate than site_url()

Reported by: johnbillion's profile johnbillion Owned by:
Milestone: Priority: major
Severity: Version: 1.0
Component: Keywords: has-patch
Cc: johnbillion

Description

Many template functions such as bp_search_form() use site_url() to print the site URL. The problem is that site_url() returns the URL of the current blog, not the main site URL.

For example, if you use bp_search_form() to print the BP search form in a member blog theme, the form action will point to the current blog and not the main site, and will produce an error when submitted.

If $bp->root_domain was used instead this would allow these template functions to be used within member blog themes.

Note that some template functions such as bp_signup_page() already use $bp->root_domain where others use site_url().

Patch coming in a lil' while.

Attachments (1)

606.patch (5.0 KB) - added by johnbillion 15 years ago.

Download all attachments as: .zip

Change History (3)

@johnbillion
15 years ago

#1 @johnbillion
15 years ago

  • Keywords has-patch added

Patch which also includes replacing some occurances of get_option('home') with $bp->root_domain to allow these functions to be used within member blog themes.

#2 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1254]) Fixes #606

Note: See TracTickets for help on using tickets.