Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#6046 closed defect (bug) (fixed)

Customizer causes BP to throw a _doing_it_wrong warning

Reported by: DJPaul Owned by: johnjamesjacoby
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc: leho@…

Description

Going to the Customizer, anywhere, causes BP to throw a _doing_it_wrong warning.

The Customizer frame load happens in _wp_customize_include, which is hooked to plugins_loaded. Our _doing_it_wrong warning triggers because this all happens before the init action occurs.

Not sure if this is a WP core issue more than ours (perhaps it hooks so early on purpose), but I'll attach a patch in case we want a workaround for now.

Attachments (1)

6046.1.patch (744 bytes) - added by DJPaul 5 years ago.

Download all attachments as: .zip

Change History (8)

@DJPaul
5 years ago

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


5 years ago

#2 @DJPaul
5 years ago

Was originally reported in #5203

#3 @slaFFik
5 years ago

  • Keywords has-patch added

#4 @johnjamesjacoby
5 years ago

  • Milestone changed from Future Release to 2.3

#5 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 9527:

Update bp_setup_current_user() to avoid output in WordPress Customizer. Fixes #6046. See #WP24169.

#6 @DJPaul
3 years ago

  • Component changed from Tools - Warnings/Notices to Core

#7 @lkraav
3 years ago

  • Cc leho@… added
Note: See TracTickets for help on using tickets.