permalinks nag message looks optional

[DJPaul]

The green colour used by the "BuddyPress is almost ready. You must update your permalink structure" message suggests, to me, that this is an optional message. In fact, it ought to be the red colour banner because if permalinks aren't set, BuddyPress doesn't work.

[DJPaul]

This actually sucks because bp_core_print_admin_notices() sticks everything in one box and it says "BuddyPress combines all its messages into a single notice, to avoid a preponderance of yellow boxes". This reads like a JJJ-style note from back in the day :), I assume we used to have many more nags -- I can't remember.

I would like to revisit this. I'd like to suggest we change this method to draw one banner box for each "type" of message (updated, error, etc)

I also recall a conversation I had with JJJ when we were in Vegas and I think he had just found a WordPress API that would have handle rendering all these custom message boxes for us, but I can't remember/find it in the codebase. Something for another future iteration, maybe.

[boonebgorges]

This reads like a JJJ-style note from back in the day :), I assume we used to have many more nags -- I can't remember.

I wrote this stuff. #blameboone

I'd like to suggest we change this method to draw one banner box for each "type" of message (updated, error, etc)

+1

[djpaul]

In 9171:

Core: admin notice functions now support a "type".

The type parameter is used to set a CSS class when the notices are
rendered in wp-admin. It defaults to “updated”, which is the same as
the previous behaviour, which is visually styled as the box with the
green border.

Fixes #6041

[djpaul]

In 9172:

Core: render the permalink nag an error message

Previously, it’s been rendering with a green border which I think helps
make people blind to the fact that we’re asking for action to be taken
(based on real-life user testing).

See #6041