Group home filters do not work when the activity component is disabled

[vimes1984]

When the activity component is deactivated and you click on a group home page, the default loaded template part is now the group members template loop:
​https://buddypress.trac.wordpress.org/browser/tags/2.1.1/src/bp-templates/bp-legacy/buddypress/groups/single/home.php#L36

If you attempt to use the dropdown filters or the ajax search functions to filter the group members, they do not work.

The JS needs some tweaking to fix this.

[vimes1984]

patched bp-legacy buddypress.js

[DJPaul]

Thanks for reporting the issue, vimes1984.

Can someone else run a diff of this file against trac? Then we can test/review, and move to an appropriate milestone.

[vimes1984]

The .min would need to be rebuilt as well..

[tharsheblows]

Here is the diff. I've only done that -- haven't looked at it yet!

[tharsheblows]

diff of buddypress.js previously uploaded

[vimes1984]

weird I only changed the first lines...

[tharsheblows]

The 3 places where you've added in this?
'home' === object && 'groups' === ...

[vimes1984]

that's the one :D

[tharsheblows]

Yay!

I can't reproduce this though. I'm creating a new group and the search and filters work. Then, even if I delete the activity about creating the group, they still work.

Can you tell me a little more about it -- ideally the exact steps to take to reproduce the issue.

[vimes1984]

I created a new group and had a list of members in it due to having no activity it defaulted onto the members loop page tempalte on the home page... and the filters nor search worked....

[vimes1984]

Christ that reads awfully...
Ok I created a group with no activity, it then defaults to the members loop on the home page of the group.
Like this neigther the search nor the filters work...
Changed themes to default removed all plugins and nada...
Using Buddypress Version 2.1.1
and Wordpress Version 4.0

[r-a-y]

I've duplicated the issue when I deactivate the activity component from "Settings > BuddyPress > Components" admin page in the WP admin dashboard.

I think the fix proposed by vimes1984 works, but needs to be tweaked to check that what is loaded on the page is the group members template part.

Assigning to myself for a closer look.

[r-a-y]

02.patch sets the object and scope when the group members template is in use.

This is better than checking explicitly for the home object as in 01.diff.

[johnjamesjacoby]

Nice work, Ray. This looks like a fine approach.

[r-a-y]

In 9305:

bp-legacy: Add better detection for the group member search field.

Previously, if the activity component is disabled and a user is on a group
homepage, the AJAX search and select dropdown would not function properly.

This commit fixes this by setting the appropriate object and scope
parameters when the group member search field is detected.

Props vimes1984 for an initial patch.

Fixes #6033.

[vimes1984]

Yeah I get props :D