Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#6029 closed enhancement (wontfix)

Compatibility with easy fancybox plugin

Reported by: alex80ks's profile alex80ks Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.1
Component: Activity Keywords:
Cc:

Description

Buddypress activity stream on my page here looks ok and images are shown ok but when i press Read more on some article there on that page, content of the article gets expanded as it should be but when i click on image from that article fancybox effect doesnt work.
Same thing for images in articles after pressing Load More.
Author of plugin was shared with me fix so i can share with you and you can maybe implement in next update of buddypress.
Read More problem solved
here is http://pastebin.com/WtZAkmRq
Load more http://pastebin.com/3gMvw6pW

thanks you

Change History (4)

#1 @DJPaul
9 years ago

  • Keywords needs-testing added

Thanks for the report, alex80ks.

It will be helpful if someone else can review this ticket and the patch, to help decide if it's something we need (or want) to fix in BP core, and if the pastebin is the best way to fix the problem. At a glance, I can't see what's new in the pastebin files.

#2 @imath
9 years ago

the pastebins are triggering a js event 'post-load' when the content is updated after a read-more click on a single activity (line 17) or after new lis has been appended into the stream (line 30).

I think the plugin is waiting for this 'post-load' event because of this line

Because the content is Ajaxed created, he requires us to trigger this event. But i think the plugin author can fix this alone. I'm thinking of something like :

jQuery( 'div.activity' ).on( 'click', 'img', function( e ) { // do stuff here } );

or more globally

jQuery( 'body' ).on( 'click', 'img', function(e) { // do stuff here } );

NB : not enough into it to be positive at 100% ;)

#3 @DJPaul
9 years ago

The post-load event is custom and triggered by Jetpack's infinite scroll feature.

#4 @DJPaul
9 years ago

  • Component changed from Core to Activity
  • Keywords needs-testing removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing this ticket; making adjustments to BuddyPress' templates to support a feature of only one plugin isn't something we really want to do.

Note: See TracTickets for help on using tickets.