Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 20 months ago

#6021 closed defect (bug) (fixed)

The filter 'bp_activity_custom_update' should default to false

Reported by: imath Owned by: imath
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit
Cc:

Description

The function bp_legacy_theme_post_update() in bp-legacy/buddypress/buddypress-functions.php contains a specific filter to allow custom updates : 'bp_activity_custom_update'.

The little trouble is that this filter is by default getting the posted object instead of false.

I suggest to fix it using the attached patch.

Attachments (1)

6021.patch (730 bytes) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (5)

@imath
6 years ago

#1 @DJPaul
6 years ago

  • Keywords commit added

Looks OK

#2 @imath
6 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 9160:

Make sure the filter 'bp_activity_custom_update' defaults to false

Fixes #6021

#3 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates

#4 @boonebgorges
20 months ago

In 12355:

Activity: Fix parameters for instance of bp_activity_custom_update filter.

This filter, introduced in [2552], is intended to allow developers to specify a
custom activity ID after posting to the "what's new" box. As originally
written, the filter didn't pass the right parameters to be properly used.
The instances of the filter that appear in bp-templates files were fixed in
[9160]; see #6021. The current changeset fixes the remaining instance.

Fixes #8054.

Note: See TracTickets for help on using tickets.