bp_use_embed_in_private_messages() does nothing

[slaFFik]

In general what I tried to achieve: give users ability to use oEmbed in personal messages.

There is a filter for this in bp_use_embed_in_private_messages().
Changing its value to true doesn't convert youtube links to embeds in private messages just like in activity stream updates. Which is a bit annoying.

Possible reason: bp_get_the_thread_message_content() (which has the filter oEmbed uses) is not called when ajax posting is submitted. But the old messages with the youtube links are not converted as well, so the problem is somewhere deeper.

[r-a-y]

Good catch, slaFFik. I don't think this ever worked correctly.

I've attached a patch that should fix this. Note that there isn't any oEmbed caching because there isn't a messages meta table.

[slaFFik]

Tested on WordPress 4.0, BuddyPress 2.1.1, 2012 theme and BP Default - it works.

[DJPaul]

So let's add a messages meta table, too.

[slaFFik]

That will be huge! Especially with ability to add "labels" or other types of inboxes! I'm talking about #5194

[r-a-y]

In 9187:

Fix oEmbed in private messages.

oEmbed caching for private messages will be in the next commit.

See #5990.

[r-a-y]

In 9188:

Messages: Add oEmbed caching.

With the introduction of the messages meta table (#3083), we are now able
to cache oEmbed responses. On subsequent fetches, we will now reference
the message cache instead of pinging the oEmbed provider.

This mirrors our functionality with BP's activity implementation of oEmbed.

See #5990.