Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#5968 closed enhancement (no action required)

Add action hook for failure to remove user favorite

Reported by: tw2113's profile tw2113 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Activity Keywords: reporter-feedback 2nd-opinion
Cc:

Description

We have an action hook that fires when bp_update_user_meta( $user_id, 'bp_favorite_activities', $my_favs ) runs inside bp_activity_remove_user_favorite() and succeeds, but we don't have a corresponding one for if it fails.

If anyone wants to patch this, please add inline phpdocs for the hook, or ping me to remind me to come back to it :)

Change History (2)

#1 @DJPaul
9 years ago

  • Keywords reporter-feedback 2nd-opinion added

I'm not sure why a failure condition needs an action to fire. It's not something I think we usually do. Do you think we need one?

#2 @DJPaul
9 years ago

  • Component changed from Core to Activity
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing this as invalid due to lack of counter-arguments from anyone else as to why we want to add this.

Note: See TracTickets for help on using tickets.