Long cookie value can lead to 414 Long Request Error resulting in BP Autocomplete AJAX failing

[psycleuk]

Although in the ticket #4606 there was a change to convert

encodeURIComponent(document.cookie)

to

bp_get_cookies()

there is still one entry of the former within jquery.autocomplete.js (now deprecated due to #5735), see ​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-core/deprecated/js/autocomplete/jquery.autocomplete.js?rev=8559#L329

Whilst waiting for #5735 to modernise all the JS should it be wise to update the existing autocomplete too?

[boonebgorges]

I think we didn't change this because it's sort of a legacy external library. That said, I don't think we've ever updated it, so I don't see any harm in the change :)

[psycleuk]

Patch for jquery.autocomplete.js

[psycleuk]

Have created a patch for the autocomplete.js, assuming that the .min version would be created automatically elsewhere. The change is what i'm already using on a site.

[boonebgorges]

If we're going to use bp_get_cookies(), then we should add BP's front-end JS as a dependency. This is a bit tricky; see #5797.

[psycleuk]

Ah I see what you mean. bp_get_cookies() is only available if the site uses the legacy buddypress.js which might not happen. How about a duplicate of that function directly within the autocomplete.js?

[boonebgorges]

Yeah, that's not a bad idea, I suppose. It'll have to be namespaced or something just in case it's loaded alongside bp-legacy's js.

[psycleuk]

Namespaced js function patch for jquery.autocomplete.js

[psycleuk]

How about the second patch? Puts the same code as bp_get_cookies() directly into the autocompleter object.

[boonebgorges]

Yup, I think this is a good way to go. I'll try to find some time to give it a final test in the next week or two, but I think this should probably be good.

[djpaul]

In 9248:

Messages: update autocomplete script to better handle long cookie values.

See #4606 for previous similiar fixes.

Fixes #5959, props psycleuk