Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5936 closed enhancement (fixed)

bp-activity-actions.php hooks documentation

Reported by: tw2113 Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Activity Keywords:
Cc:

Description

Document each action and filter hook in the bp-activity-actions.php file.

Attachments (3)

bp-activity-actions-5936.diff (6.1 KB) - added by tw2113 6 years ago.
bp-activity-actions-5936-1.diff (6.4 KB) - added by tw2113 6 years ago.
Diff refresh
bp-activity-actions-5936-2.diff (6.5 KB) - added by tw2113 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @tw2113
6 years ago

Attached for review/QA

#2 @boonebgorges
6 years ago

Thanks - this is looking pretty good. Couple points:

  • Our standard for @since is: @since BuddyPress (1.2.2)
  • Always use x.y.z for @since. Major versions are x.y.0.
  • No need for two spaces between since/param and the values if you're not aligning with another attribute.


@tw2113
6 years ago

Diff refresh

#3 @tw2113
6 years ago

Attached an updated copy with the changes noted above.

#4 @boonebgorges
6 years ago

  • Component changed from Core to Activity
  • Milestone changed from Awaiting Review to 2.2

Thanks, but you missed a couple @since annotations: BuddyPress (x.y.z)

#5 @tw2113
6 years ago

Bah. Rough first full day. I'll get my flow better in time.

#6 @espellcaste
6 years ago

Just a small typo in the first comment. You wrote "componants" instead of "components".

#7 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9079:

Hook documentation for bp-activity-actions.php.

Props tw2113, espellcaste.
Fixes #5936.

#8 @tw2113
6 years ago

Good catch espellcaste, and thanks Boone for making sure it got fixed.

Note: See TracTickets for help on using tickets.