Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 10 years ago

#5933 closed defect (bug) (fixed)

Warning on error log for bp_modify_page_title()

Reported by: slaFFik Owned by: djpaul
Priority: normal Milestone: 2.2
Component: Core Version:
Severity: normal Keywords: has-patch
Cc:

Description

Always getting these errors in pair on front-end:

PHP Warning:  Missing argument 2 for bp_modify_page_title() in /home/domains/cosydale.com/www/wp-content/plugins/buddypress/bp-core/bp-core-filters.php on line 426, referer: http://cosydale.com/wp-admin/index.php
PHP Warning:  Missing argument 3 for bp_modify_page_title() in /home/domains/cosydale.com/www/wp-content/plugins/buddypress/bp-core/bp-core-filters.php on line 426, referer: http://cosydale.com/wp-admin/index.php

Because of search robots, error log file is polluted very quickly.

Attachments (2)

5933.patch​ (602 bytes ) - added by imath 12 years ago.
5933.2.patch​ (549 bytes ) - added by whyisjake 12 years ago.
Keep the first parameter without a default.

Download all attachments as: .zip

Change History (10)

#1 @slaFFik
12 years ago

  • Component Core → Warnings/Notices

@imath
12 years ago

#2 @imath
12 years ago

  • Keywords has-patch reporter-feedback added

hi slaFFik,

Could you test 5933.patch to see if it solves the warnings ?

#3 @slaFFik
12 years ago

Tested, no more such warnings, turbo @image.

#4 @imath
12 years ago

  • Keywords reporter-feedback removed
  • Milestone Awaiting Review → 2.2

#5 @DJPaul
12 years ago

A filter callback function requires at least one parameter, so I don't see why the first parameter needs to be optional.

@whyisjake
12 years ago

Keep the first parameter without a default.

#6 @whyisjake
12 years ago

Here is another patch, with the first option staying the same.

#7 @djpaul
12 years ago

  • Owner set to djpaul
  • Resolution → fixed
  • Status new → closed

In 9108:

Core: Page title: make the 2nd/3rd params for bp_modify_page_title optional and provide defaults.

Prevents PHP Warnings caused by other plugins/themes.

Fixes #5933, props imath and whyisjake.

#8 @DJPaul
10 years ago

  • Component Tools - Warnings/Notices → Core
Note: See TracTickets for help on using tickets.