Warning on error log for bp_modify_page_title()

[slaFFik]

Always getting these errors in pair on front-end:

PHP Warning:  Missing argument 2 for bp_modify_page_title() in /home/domains/cosydale.com/www/wp-content/plugins/buddypress/bp-core/bp-core-filters.php on line 426, referer: http://cosydale.com/wp-admin/index.php
PHP Warning:  Missing argument 3 for bp_modify_page_title() in /home/domains/cosydale.com/www/wp-content/plugins/buddypress/bp-core/bp-core-filters.php on line 426, referer: http://cosydale.com/wp-admin/index.php

Because of search robots, error log file is polluted very quickly.

[imath]

hi slaFFik,

Could you test 5933.patch to see if it solves the warnings ?

[slaFFik]

Tested, no more such warnings, turbo @image.

[DJPaul]

A filter callback function requires at least one parameter, so I don't see why the first parameter needs to be optional.

[whyisjake]

Keep the first parameter without a default.

[whyisjake]

Here is another patch, with the first option staying the same.

[djpaul]

In 9108:

Core: Page title: make the 2nd/3rd params for bp_modify_page_title optional and provide defaults.

Prevents PHP Warnings caused by other plugins/themes.

Fixes #5933, props imath and whyisjake.