Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5910 closed defect (bug) (fixed)

travis-ci tests fail on PHP 5.2

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.1
Component: Build/Test Tools Keywords: has-patch 2nd-opinion
Cc:

Description

wordpress.org recently began forcing SSL for all requests. This includes buddypress.trac.wordpress.org requests. Our unit test suite queries buddypress.trac.wordpress.org to query for open tickets, in order to skip tickets associated with those open tickets. However, the change on wordpress.org means that this query fails when the requesting server does not support SSL; as a result, no open tickets are identified, and all tests are run, including those that are known to fail. This causes particular problems on travis-ci: we run our builds against PHP 5.2, but the travis-ci build of PHP 5.2 does not have openssl http://docs.travis-ci.com/user/languages/php/#PHP-installation

We have three options:

  1. Do nothing and continue to let our builds fail on travis-ci
  2. Stop running builds against PHP 5.2
  3. Set up a non-SSL mirror where an open ticket cache can be fetched by builds that don't have access to SSL

All of these options are pretty lame, but IMO number 3 is the best: travis-ci, and in particular the 5.2 builds, are valuable enough that we should make an attempt to save them.

I've written a small script that serves as a mirror for BP open tickets: http://hardg.com/bp-open-tickets/query (warning - CSV download). Results are cached for 15 minutes. Here is the necessary patch for BP: https://github.com/boonebgorges/BuddyPress/commit/f4430bbb8562ddd625514e93bb707f061d5533eb Obviously, it is not terribly elegant to store this on my own server, but I think it's our best option (until travis-ci fixes PHP 5.2, or we stop supporting it, or pigs fly).

Change History (3)

#1 @DJPaul
5 years ago

This looks pretty good. Thanks for working on it, and for providing a mirror on your own server.

#2 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9053:

During unit tests, use non-SSL mirror for Trac ticket cache when openssl is not enabled

This change is necessary to ensure that tests against open tickets are
properly skipped when running the test suite in environment where openssl is
not available (due to a change in wordpress.org infrastructure that forces all
traffic over SSL). It's primarily an issue on travis-ci's PHP 5.2 build, but
could arise in any situation where PHP was not built with openssl support.

This fallback can be removed when PHP 5.2.x support is dropped at some point in
the future.

Fixes #5910

This ticket was mentioned in Slack in #buddypress by boone. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.