#5910 closed defect (bug) (fixed)
travis-ci tests fail on PHP 5.2
Reported by: | boonebgorges | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 2.2 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Build/Test Tools | Keywords: | has-patch 2nd-opinion |
Cc: |
Description
wordpress.org recently began forcing SSL for all requests. This includes buddypress.trac.wordpress.org requests. Our unit test suite queries buddypress.trac.wordpress.org to query for open tickets, in order to skip tickets associated with those open tickets. However, the change on wordpress.org means that this query fails when the requesting server does not support SSL; as a result, no open tickets are identified, and all tests are run, including those that are known to fail. This causes particular problems on travis-ci: we run our builds against PHP 5.2, but the travis-ci build of PHP 5.2 does not have openssl http://docs.travis-ci.com/user/languages/php/#PHP-installation
We have three options:
- Do nothing and continue to let our builds fail on travis-ci
- Stop running builds against PHP 5.2
- Set up a non-SSL mirror where an open ticket cache can be fetched by builds that don't have access to SSL
All of these options are pretty lame, but IMO number 3 is the best: travis-ci, and in particular the 5.2 builds, are valuable enough that we should make an attempt to save them.
I've written a small script that serves as a mirror for BP open tickets: http://hardg.com/bp-open-tickets/query (warning - CSV download). Results are cached for 15 minutes. Here is the necessary patch for BP: https://github.com/boonebgorges/BuddyPress/commit/f4430bbb8562ddd625514e93bb707f061d5533eb Obviously, it is not terribly elegant to store this on my own server, but I think it's our best option (until travis-ci fixes PHP 5.2, or we stop supporting it, or pigs fly).
This looks pretty good. Thanks for working on it, and for providing a mirror on your own server.