Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5908 closed defect (bug) (fixed)

Wrong button title

Reported by: SGr33n Owned by: boonebgorges
Priority: normal Milestone: 2.2
Component: Messages Version:
Severity: normal Keywords: good-first-bug has-patch
Cc:

Description

Hi,

On members/single/messages/single.php there is a button with title "Delete Message", I think it should be "Delete Conversation".

Attachments (2)

delete-conversation.patch​ (925 bytes ) - added by SGr33n 12 years ago.
Button Delete Conversation
del-convers-button.patch​ (1.8 KB ) - added by SGr33n 12 years ago.
This includes single.php and messages-loop.php

Download all attachments as: .zip

Change History (8)

#1 @DJPaul
12 years ago

  • Component Core → Messaging
  • Keywords good-first-bug added
  • Milestone Awaiting Review → Future Release

I think this is a good idea. Do you want to work on a patch for this? (And are there any other places within the Messages templates that we'd need to also change?)

#2 @SGr33n
12 years ago

Sure, here it is :) There was also on messages-loop.php.

@SGr33n
12 years ago

Button Delete Conversation

#3 @SGr33n
12 years ago

  • Keywords has-patch added

@SGr33n
12 years ago

This includes single.php and messages-loop.php

#4 @joshshashaty
12 years ago

Tested patch myself, looks good.

#5 @boonebgorges
12 years ago

  • Owner set to boonebgorges
  • Resolution → fixed
  • Status new → closed

In 9089:

Change 'Delete Message' to 'Delete Conversation' on message delete title button.

This makes it clearer what the button actually does.

Props SGr33n, joshshashaty.
Fixes #5908.

#6 @DJPaul
12 years ago

  • Milestone Future Release → 2.2
Note: See TracTickets for help on using tickets.