Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5908 closed defect (bug) (fixed)

Wrong button title

Reported by: SGr33n Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Messages Keywords: good-first-bug has-patch
Cc:

Description

Hi,

On members/single/messages/single.php there is a button with title "Delete Message", I think it should be "Delete Conversation".

Attachments (2)

delete-conversation.patch (925 bytes) - added by SGr33n 6 years ago.
Button Delete Conversation
del-convers-button.patch (1.8 KB) - added by SGr33n 6 years ago.
This includes single.php and messages-loop.php

Download all attachments as: .zip

Change History (8)

#1 @DJPaul
6 years ago

  • Component changed from Core to Messaging
  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

I think this is a good idea. Do you want to work on a patch for this? (And are there any other places within the Messages templates that we'd need to also change?)

#2 @SGr33n
6 years ago

Sure, here it is :) There was also on messages-loop.php.

@SGr33n
6 years ago

Button Delete Conversation

#3 @SGr33n
6 years ago

  • Keywords has-patch added

@SGr33n
6 years ago

This includes single.php and messages-loop.php

#4 @joshshashaty
6 years ago

Tested patch myself, looks good.

#5 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9089:

Change 'Delete Message' to 'Delete Conversation' on message delete title button.

This makes it clearer what the button actually does.

Props SGr33n, joshshashaty.
Fixes #5908.

#6 @DJPaul
6 years ago

  • Milestone changed from Future Release to 2.2
Note: See TracTickets for help on using tickets.