Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#5895 closed defect (bug) (wontfix)

bp-default - media screen css error when minifying

Reported by: danbp Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.1
Component: Templates Keywords: needs-patch
Cc:

Description

Possible css error on media screen.

See related post for more details
https://buddypress.org/support/topic/issue-with-w3-total-cache/

Change History (7)

#1 @r-a-y
6 years ago

  • Component changed from Core to Theme
  • Summary changed from media screen css error to bp-default - media screen css error when minifying

The problem referenced in the thread is with the bp-default theme and not bp-legacy:
https://buddypress.trac.wordpress.org/browser/tags/2.0.3/bp-themes/bp-default/_inc/css/responsive.css#L121

I don't know if we should open up the "Issues" tab on the Github bp-default repo for things like this.

#2 @boonebgorges
6 years ago

  • Keywords needs-patch added

What's the correct syntax?

I don't know if we should open up the "Issues" tab on the Github bp-default repo for things like this.

Seems like it might be easier to keep issues here until the status of bp-default has changed a bit more - like when other people are committing to it. Happy to hear other opinions though.

#3 @r-a-y
6 years ago

What's the correct syntax?

We need to add a selector when using the -webkit-text-size-adjust rule:

Here's a potential fix:

@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
   #buddypress {
        -webkit-text-size-adjust: none;
   } 
}

However, I'm not too familiar with this rule, so need some feedback here.

---

Seems like it might be easier to keep issues here until the status of bp-default has changed a bit more - like when other people are committing to it.

I'm okay with this.

#4 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to Future Release

If someone wants to test and patch this and send a pull request on Github, we're happy to merge it in.

#5 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates

#6 @DJPaul
3 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#7 @DJPaul
3 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.