Opened 10 years ago
Closed 10 years ago
#5884 closed defect (bug) (fixed)
Inconsistent activation_key update/delete
Reported by: | johnjamesjacoby | Owned by: | djpaul |
---|---|---|---|
Milestone: | 2.2 | Priority: | high |
Severity: | normal | Version: | 2.0 |
Component: | Members | Keywords: | has-patch |
Cc: |
Description
In bp_core_activate_signup()
we use bp_update_user_meta()
which allows the key to be filtered, but in bp_core_signup_user()
we use update_user_meta()
so this meta can never be overridden.
I'd like to lobby that we switch the later call to bp_update_user_meta()
both for consistency and flexibility.
The use-case for per-network activation keys is extremely edge, though... I am in the process of implementing something that will use this (similar in design to triggering a password reset from WordCamp.org, and not wanting to be able to finalize that request through BuddyPress.org.)
Putting this into 2.1.1 as it's a very small edit that likely does not impact any existing installations, but we're so close to 2.1 it doesn't feel right to sneak it in.
Attachments (1)
Change History (8)
#2
@
10 years ago
I don't have a problem making the swap. I'm not sure why this one was left as update_user_meta()
. Probably an oversight.
In the absence of a strong reason to the contrary (ideally other than "you'd like it sooner"), I'd prefer to see this in the 2.2 milestone. It's not a regression. I know there are ways you could work around it in the meantime :)
This ticket was mentioned in IRC in #buddypress-dev by jjj. View the logs.
10 years ago
#5
@
10 years ago
- Milestone changed from 2.1.1 to 2.2
2.2 is fine. The best reason I can come up with is messed up activation keys for anyone running multiple BuddyPress networks, of which I suspect there are very few.
Worth noting this is our only remaining call directly to
update_user_meta()
that isn't passed throughbp_ update_user_meta()
.