Opened 10 years ago
Closed 10 years ago
#5876 closed defect (bug) (fixed)
Unit tests against unclosed tickets not being skipped correctly
Reported by: | boonebgorges | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 2.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | |
Cc: |
Description
Marking a unit test with @ticket BP1234
should cause the test to be skipped if ticket 1234 is not closed (unless forcing all tests or running that specific test group). This is not currently working, with result that the suite is failing on Travis CI and elsewhere.
The cause appears to be this:
- We're passing http://buddypress.trac.wordpress.org (non-SSL) to
TracTickets::isTracTicketClosed
in BP_UnitTestCase::knownBPbug() - When the TracTickets class goes to fetch this content, the wordpress.org servers are redirecting away from the non-SSL version to the SSL version
- During the redirect, the URL-encoded exclamation point in
%21closed
is being re-encoded as%2521closed
(%25
is a URL-encoded%
). This breaks thestatus=!closed
param. Trac doesn't know what to do with the invalidstatus
, so it returns an empty set of ticket IDs - As such, TracTickets thinks that no tickets are unclosed on BP (would that this were the case), which means that that open-ticket tests are not being skipped
Change History (1)
Note: See
TracTickets for help on using
tickets.
In 9022: