Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 3 years ago

#5875 closed enhancement (maybelater)

consolidate display of activities and notifications

Reported by: SGr33n Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Activity Keywords: trac-tidy-2018
Cc:

Description

Hi,

BuddyPress updated_profile activity action has a Throttle time. I was thinking that also other activities, like New Avatar should have a throttle time... could also happen that an user is trying more than one Avatar, so multiple activity actions will added on his activity, but other users just need to know about the last one.

Also customized activities could need a throttle time, so why don't centralize it in bp_activity_add, adding a new $arg parameter?

Attachments (2)

bp-activity-functions-throttle.php (70.1 KB) - added by SGr33n 7 years ago.
5875.01.patch (1.6 KB) - added by r-a-y 7 years ago.

Download all attachments as: .zip

Change History (7)

@r-a-y
7 years ago

#1 @r-a-y
7 years ago

01.patch is a patch based from SGr33n's entire file upload.

I like the idea of throttling.

However, I do see one major UX problem. Let's say bp_activity_add() returns false because it was throttled, how do we notify the user of this? We currently do not use WP_Error so we cannot determine what type of problem that bp_activity_add() returns.

Switching to WP_Error might be beneficial in the long run, but we've been using boolean return values for so long that a change might break a few things.

---

I was thinking that also other activities, like New Avatar should have a throttle time... could also happen that an user is trying more than one Avatar, so multiple activity actions will added on his activity, but other users just need to know about the last one.

If multiple activity items are being added when a user uploads a new avatar each time, then this seems like a bug to me.

#2 @r-a-y
7 years ago

  • Component changed from Core to Activity

#3 @DJPaul
7 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from bp_activity_add to have a throttle time arg to consolidate display of activities and notifications

I think rather than going along the lines of throttling activity inserts, BP should be smarter about how it queries and displays multiple instances of the same kind of activity data. There's a lot of parallels between this and the Notifications toolbar, too.

For example, on WordPress.com, if a user "likes" a blog post, you get a notification that says that. If three people like the same post, the original notification re-appears but now says "x, y, and z, liked your post", and if you have many likes, it becomes something like "x, y, and 431 other people liked your post" - but there's still a "like" recorded for each user. Having 433 individual like notifications would suck. :)

BP's Notifications needs to eventually work like this, and there's no reason our activity stream items shouldn't do something similar, but these are big ideas and we should take time carefully to think about the implementation.

#4 @DJPaul
3 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#5 @DJPaul
3 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.