Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#5872 closed enhancement (fixed)

auto-linking for semicolon-separated lists in xprofile

Reported by: jreeve Owned by: djpaul
Milestone: 2.8 Priority: normal
Severity: normal Version: 1.1
Component: Extended Profile Keywords: has-patch
Cc: jon.reeve@…

Description

Xprofile will automatically create hyperlinks out of many comma-separated lists, but doesn't behave well when semicolons are used instead of or in conjunction with commas.

A lot of our users use semicolons to separate items in their interests lists, especially when some of those items contain commas:

Interests: interest one; interest two; comma, interest three.

A solution would be to allow semicolons as delineators in addition to commas. I'll submit a patch for this.

Since I haven't submitted many patches to BP yet, please let me know if I'm doing the patch submission correctly.

Attachments (3)

5872.patch (1.1 KB) - added by jreeve 5 years ago.
5872-semicolon-delimiter.diff (1.3 KB) - added by tw2113 3 years ago.
5872-semicolon-delimiter-2.diff (1.3 KB) - added by tw2113 3 years ago.

Download all attachments as: .zip

Change History (15)

@jreeve
5 years ago

#1 @jreeve
5 years ago

  • Type changed from defect (bug) to enhancement

#2 @jreeve
5 years ago

  • Cc jon.reeve@… added

#3 @DJPaul
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.2

Hi @jreeve!

Thank you for the patch. :) It looks to be in the correct format and, at a quick glance, the code change itself seems to be pretty good. During this current release cycle (2.1), we had spoken a bit about the auto-linking behaviour in xprofile -- see #787 -- so this kind of sits together with that nicely.

In the end, we ran out of time/volunteers to get the changes discussed in that ticket ready for 2.1, so I'm going to move your ticket to our 2.2 milestone, which means we'll come back and revisit this ticket when we start work on the 2.2 cycle, which will probably be about a month from now. It'd be great to have your thoughts on the #787 ticket as well.

Thanks again for the patch.

#4 @DJPaul
5 years ago

  • Milestone changed from 2.2 to Future Release

#5 @DJPaul
4 years ago

  • Keywords needs-refresh added; has-patch removed

#6 @tw2113
3 years ago

  • Keywords has-patch added; needs-refresh removed

Updated patch to almost match what @jreeve provided originally, with some slight codesniffer cleanups.

#7 @DJPaul
3 years ago

  • Milestone changed from Future Release to 2.8

Don't patch things and leave them in Future Release, they'll never get seen!

#8 @DJPaul
3 years ago

  • Keywords needs-patch added; has-patch removed

@tw2113 The only change I would suggest is that we check for commas before semi-colons. If a string has both, splitting it on the commas will match existing behaviour. (I think. Only had a quick read).

#9 @tw2113
3 years ago

Updated and switched the order in the two spots.

#10 @tw2113
3 years ago

  • Keywords has-patch added; needs-patch removed

#11 @djpaul
3 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11287:

xprofile: add support for auto linking semicolon-separated field values.

Fixes #5872

Props jreeve, tw2113

#12 @DJPaul
3 years ago

@jreeve I am very sorry this took two years to get in. We'll try to do better in the future. Thank you for your contribution.

Note: See TracTickets for help on using tickets.