Skip to:
Content

Opened 4 years ago

Last modified 4 years ago

#5865 assigned defect (bug)

URI parsing fails for encoded url slugs.

Reported by: eltobiano Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-patch needs-unit-tests
Cc: jose@…

Description

URI path for encoded laguages sometimes returns an uppercase string.
The comparison is plain, so therefore the slug is not matching when it should.

The issue happens when using a custom component in a Buddypress installation running on a language that needs encoded URL, like Korean.

The problem was original posted and fixed here:
http://premium.wpmudev.org/forums/topic/a-few-questions-about-the-bp-group-calendar

Attachments (1)

bp-core-catchuri.php (25.4 KB) - added by WPMUDEV 4 years ago.
Patch added in line 60.

Download all attachments as: .zip

Change History (7)

#1 @boonebgorges
4 years ago

  • Keywords needs-unit-tests added
  • Milestone changed from Awaiting Review to 2.2

@WPMUDEV
4 years ago

Patch added in line 60.

#2 @DJPaul
4 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#3 @DJPaul
4 years ago

I can't get a test to demonstrate the reported behaviour, though I'm pretty sure it must occur. I've diff'd what I've done here in case anyone else wants to look at this: https://gist.github.com/paulgibbs/77213ac6984e5ee19310

test_case_insensitivity_of_router_slugs is failing (as expected -- the fix reported by the original reporter resolves it), but test_case_insensitivity_of_urlencoded_router_slugs passes just fine.

#4 @DJPaul
4 years ago

  • Owner DJPaul deleted

#5 @DJPaul
4 years ago

See also #5353

#6 @DJPaul
4 years ago

  • Milestone changed from 2.2 to Future Release
Note: See TracTickets for help on using tickets.