Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#5852 closed defect (bug) (worksforme)

sitewide notices UI clash between displayed notice and all notice screen rendering

Reported by: hnla's profile hnla Owned by:
Milestone: Priority: low
Severity: normal Version:
Component: Messages Keywords:
Cc: hnla

Description

We have an somewhat confusing experience here.

When composing a sitewide notice you can in fact embed urls, add bold tags and those will be correctly displayed back when viewing the messages > notices screen; however we display the actual sitewide notice stripping out these tags as we run $notice->subject through 'wp_filter_kses'

Clearly this is confusing for admins and needs to be one or other.

I have had a need to update usefulness of sitewide notices and yanked the 'bp_message_get_notices' out of bp-messages-template to run elsewhere with modified markup and running the 'subject' through bp_activity_filter_kses() to gain a few allowed tags as well as wpautop()

I suggest we do something similar or conversely we ensure that the notices screen accurately represents what is going to be displayed and remove whatever filter is being allowed on that screen for list displayed notices.

Change History (5)

#1 @hnla
10 years ago

  • Type changed from enhancement to defect (bug)

#2 @hnla
10 years ago

Edit In haste to accommodate changes for user missed the fact that we do actually allow for basic inline tags, only slight issue is allowing conversion of http strings to anchors in notice screen but not in displayed sitewide notice.

#3 @DJPaul
9 years ago

  • Milestone changed from Awaiting Review to 2.2

#4 @DJPaul
9 years ago

  • Milestone 2.2 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

On testing with bold and italic tags, I cannot find an area where BP outputs the sitewide notice where it strips the tags out -- they are being rendered as expected.

We'll need more details about the theme and exactly where to go to recreate this if it's still an issue.

#5 @hnla
9 years ago

Edit In haste to accommodate changes for user missed the fact that we do actually allow for basic inline tags, only slight issue is allowing conversion of http strings to anchors in notice screen but not in displayed sitewide notice.

Note: See TracTickets for help on using tickets.