Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#5846 closed defect (bug) (fixed)

bp-legacy: "Blog Details" block not toggled on registration page

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.2 Priority: normal
Severity: normal Version: 1.7
Component: Appearance - Template Pack Keywords: has-patch commit
Cc:

Description

In multisite, on the registration page and if blog registration is allowed, we show a blog creation form.

However, this form shouldn't be shown if the "Yes, I'd like to create a new site" checkbox is unchecked.

bp-default used to do this; I don't think this functionality was ever ported to bp-legacy.

Attached patch ports this feature over to bp-legacy.

Attachments (1)

5846.01.patch (806 bytes) - added by r-a-y 6 years ago.

Download all attachments as: .zip

Change History (6)

@r-a-y
6 years ago

#1 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to 2.2

There must be a better way to do this (i.e. set it in HTML rather than change late with JS), but a good spot, nonetheless.

#2 @DJPaul
6 years ago

  • Keywords reporter-feedback added

Is this implementation the same as to how BP-Default dealt with it?

#3 @r-a-y
6 years ago

  • Keywords reporter-feedback removed

Is this implementation the same as to how BP-Default dealt with it?

No it's not.

There was some inline JS in bp-default:
https://buddypress.trac.wordpress.org/browser/tags/1.9/bp-themes/bp-default/registration/register.php#L287

#4 @DJPaul
6 years ago

  • Keywords commit added

Looks good

#5 @r-a-y
6 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 9250:

bp-legacy: Add JS to toggle the "Blog Details" block on registration page.

When theme compatibility was introduced in BuddyPress 1.7, the javascript
to toggle the site registration form fields was not ported over from
bp-default. This commit brings back this functionality to bp-legacy.

Fixes #5846.

Note: See TracTickets for help on using tickets.