bp-legacy: "Blog Details" block not toggled on registration page

[r-a-y]

In multisite, on the registration page and if blog registration is allowed, we show a blog creation form.

However, this form shouldn't be shown if the "Yes, I'd like to create a new site" checkbox is unchecked.

bp-default used to do this; I don't think this functionality was ever ported to bp-legacy.

Attached patch ports this feature over to bp-legacy.

[DJPaul]

There must be a better way to do this (i.e. set it in HTML rather than change late with JS), but a good spot, nonetheless.

[DJPaul]

Is this implementation the same as to how BP-Default dealt with it?

[r-a-y]

Is this implementation the same as to how BP-Default dealt with it?

No it's not.

There was some inline JS in bp-default:
​https://buddypress.trac.wordpress.org/browser/tags/1.9/bp-themes/bp-default/registration/register.php#L287

[DJPaul]

Looks good

[r-a-y]

In 9250:

bp-legacy: Add JS to toggle the "Blog Details" block on registration page.

When theme compatibility was introduced in BuddyPress 1.7, the javascript
to toggle the site registration form fields was not ported over from
bp-default. This commit brings back this functionality to bp-legacy.

Fixes #5846.