Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 6 years ago

#5842 closed enhancement (maybelater)

add more CSS classes secondary activity avatar

Reported by: sgr33n's profile SGr33n Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-patch, good-first-bug, trac-tidy-2018
Cc:

Description

Hi,

I would suggest to add some classes to the activity entry:

First of all a class for the user link, now it's:

<a title="SGr33n" href="http://www.buddypress.org/users/sgr33n/">SGr33n</a>

Would be:

<a class="author username me" title="SGr33n" href="http://www.buddypress.org/users/sgr33n/">SGr33n</a>

Could be also useful to add the class for the second username, it happens e.g. on friendship_created:

<a class="author username me" title="Sergio" href="http://www.buddypress.org/users/sergio/">Sergio</a>
and
<a class="" href="http://www.buddypress.org/users/sgr33n">
<img class="avatar user-1-avatar avatar-20 photo" width="20" height="20" alt="Foto del profilo di SGr33n" src="http://ww4.ircaserta.com/wp-content/uploads/avatars/1/3047da0262dfccd6795722f43a636a6e-bpthumb.jpg">
</a>
<a class="second-username" title="SGr33n" "http://www.buddypress.org/users/sgr33n"">SGr33n</a> are now friends

In this second activity entry, then, looks like the avatar should have a class, infact it's null.

Thanks :)

Change History (5)

#1 @DJPaul
10 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.2
  • Summary changed from Activity entry useful class to add more CSS classes secondary activity avatar

#2 @DJPaul
9 years ago

  • Keywords good-first-bug added

#3 @DJPaul
9 years ago

  • Milestone changed from 2.2 to Future Release

#4 @DJPaul
6 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#5 @DJPaul
6 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.