Opened 10 years ago
Closed 10 years ago
#5840 closed enhancement (fixed)
Welcome Screen: Enhance new installations welcome panel
Reported by: | mercime | Owned by: | djpaul |
---|---|---|---|
Milestone: | 2.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch |
Cc: | mercijavier@… |
Description
Attached image shows the before and after screenshots of the welcome section for admins of new BuddyPress installations.
Using most of the styles and layout of the WordPress welcome screen in dashboard.php, the first column shows the list and links to Settings > BuddyPress panels, the second column lists the BP panels in wp-admin, and the third column shows the links to the support forums and codex.
Patch to follow.
Attachments (6)
Change History (22)
#5
@
10 years ago
This is a good idea! Some feedback, and I appreciate some of the suggestions are to do with parts of the existing code/text, not because of your improvements:
- "...community of BuddyPress users and developers is waiting..." -> are waiting.
- "Create/Manage Groups" maybe should be just "Manage Groups", or keep the old title and link to the front-end of the site. Front-end group creation is a pretty big part of Groups.
- "Manage Signups" -> "Manage User Signups"
#6
@
10 years ago
"...community of BuddyPress users and developers is waiting..." -> are waiting.
American vs British English. We should make a decision about this and apply project-wide.
Other suggestions look good to me.
#7
@
10 years ago
- Cc mercijavier@… added
Thank you all for your positive feedback. Crossing my fingers that there will be no changes in WP core's admin markup/classes/styles just before 4.0 is released.
I believe we're good to go using a singular verb as it is referring to "a vibrant community" and not the prepositional phrase "of BuddyPress users and developers." Attached is an image of the sentence diagram of that specific section for reference.
Inclined to choose "Manage Groups" with link to wp-admin panel as all links in that list refer to such and user might be surprised that he/she suddenly is in the front end screen. Having said that, I will do whatever you decide :)
10-4 on "Manage Signups" -> "Manage User Signups"
#8
@
10 years ago
I believe we're good to go using a singular verb as it is referring to "a vibrant community" and not the prepositional phrase "of BuddyPress users and developers." Attached is an image of the sentence diagram of that specific section for reference.
Gah, let's not start fights. It really is a Britishism :) http://english.stackexchange.com/questions/1338/are-collective-nouns-always-plural-or-are-certain-ones-singular I think the policy is for American spellings in public text, so we should go with American usage in this case too.
#9
@
10 years ago
Peace. Please know that I would rather walk across red hot coals than start fights, especially with Paul. Was totally unaware of that Britishism, thanks for the link Boone. Revised patch to follow.
#11
@
10 years ago
One day, the Queen (or King) will visit you folks again and enlighten your country about plural collective nouns. Until then, I'll try to get the en-GB translation for BP done in the next couple of months so this kind of thing doesn't drive me totally crazy.
#12
@
10 years ago
- Owner set to djpaul
- Resolution set to fixed
- Status changed from new to closed
In 8980:
5840.1.patch removed the conditional added and brings back the hr which were inadvertently added/removed in previous patch.