Skip to:

Opened 10 years ago

Closed 9 years ago

Last modified 8 years ago

#5826 closed defect (bug) (fixed)

Revisions to add/remove friendship buttons JS has omitted user account screens

Reported by: hnla's profile hnla Owned by: djpaul's profile djpaul
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc: hnla


Currently in buddypress user account screens header action buttons for friends are not Ajaxed!

Tracking back:

In earlier versions (1.7.1 L902) BP JS ran:
jq(".friendship-button a").on('click', function() {

In 1.7.2 we've changed to:
jq('#members-dir-list').on('click', '.friendship-button a', function() {

changed in: Changeset 6972

Now we have become rather specific to the members dir only!

In the latest revision L1203 we have:

jq( '#members-dir-list, #members-group-list' ).on('click', '.friendship-button a', function() {

Members group buttons have been added in.

I was checking some Ajax issues and having resolved was puzzled why the bp_user screens buttons were still not working.

Seems like we have one more token to add in :) :
jq( '#members-dir-list, #members-group-list, #item-header' ).on('click', '.friendship-button a', function() {

This kicked things back into life.

Not sure though why the change to querying for those selectors when we didn't before, does that not just impose a degree of overhead to this function?

I am wondering though whether I'm missing something that this hasn't been raised before by anyone?

Attachments (1)

5826.patch (646 bytes) - added by hnla 9 years ago.
Enable user account screen Ajax for friend button

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in IRC in #buddypress-dev by hnla. View the logs.

10 years ago

#2 @DJPaul
10 years ago

  • Component changed from Core to Theme
  • Milestone changed from Awaiting Review to 2.2

#3 @DJPaul
9 years ago

  • Milestone changed from 2.2 to Future Release

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.

9 years ago

9 years ago

Enable user account screen Ajax for friend button

#5 @hnla
9 years ago

  • Keywords has-patch added
  • Milestone changed from Future Release to 2.2

I've added an id to the selector group to correct the omission of user account friend button ajax. This was an error and needs to be corrected for this release.

#6 @djpaul
9 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 9277:

Templates: fix regression in AJAX functionality for Add/Remove Friends button on user account screens.

Fixes #5826, props hnla

#7 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.