#5826 closed defect (bug) (fixed)
Revisions to add/remove friendship buttons JS has omitted user account screens
| Reported by: | hnla | Owned by: | djpaul |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.2 |
| Component: | Templates | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | hnla |
Description
Currently in buddypress user account screens header action buttons for friends are not Ajaxed!
Tracking back:
In earlier versions (1.7.1 L902) BP JS ran:
jq(".friendship-button a").on('click', function() {
In 1.7.2 we've changed to:
jq('#members-dir-list').on('click', '.friendship-button a', function() {
changed in: Changeset 6972
Now we have become rather specific to the members dir only!
In the latest revision L1203 we have:
jq( '#members-dir-list, #members-group-list' ).on('click', '.friendship-button a', function() {
Members group buttons have been added in.
I was checking some Ajax issues and having resolved was puzzled why the bp_user screens buttons were still not working.
Seems like we have one more token to add in :) :
jq( '#members-dir-list, #members-group-list, #item-header' ).on('click', '.friendship-button a', function() {
This kicked things back into life.
Not sure though why the change to querying for those selectors when we didn't before, does that not just impose a degree of overhead to this function?
I am wondering though whether I'm missing something that this hasn't been raised before by anyone?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Enable user account screen Ajax for friend button