Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5812, comment 3


Ignore:
Timestamp:
08/13/2014 05:47:30 PM (10 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5812, comment 3

    initial v1  
    11> A more conservative approach is to bail at the beginning of user_meets_access_condition() if $this->group_id is empty. Will that take care of the db queries?
    22
    3 Yup, that works.  However, there is a backward compatibility block before that, which does a `groups_get_group()` call.
     3Yup, that works.  However, there is a backward compatibility block before that, which does a `groups_get_group()` call.  (It doesn't run for me at the moment, but just wanted to list that.)
    44
    55Could the group ID check go at the very beginning of the `setup_access_settings()` method?