Skip to:
Content

BuddyPress.org

Opened 5 years ago

Last modified 3 years ago

#5800 new defect (bug)

wp_title filter can break BP's pages' titles

Reported by: sooskriszta Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc: vivek@…

Description

On Groups pages, the page Title should include the Group's name. At the moment it just says Groups.

Change History (12)

#1 @sooskriszta
5 years ago

  • Cc vivek@… added

#2 @DJPaul
5 years ago

  • Keywords reporter-feedback added

Seems to be working fine for me. sooskriszta, what version of BP did you test with, and with what theme? Thanks.

#3 @sooskriszta
5 years ago

  • Keywords reporter-feedback removed

Not for me.

I am using WordPress 3.9.3, BuddyPress 2.0.2, and Weaver II Pro 2.1.10

Could you share a link for your test install?

#4 @sooskriszta
5 years ago

  • Summary changed from Page Title should show Group name to Page Title should show Group/Member name

By the way, same issue applies to member profile pages too. Instead of Member's name, the title says only "Members"

#5 @DJPaul
5 years ago

My test install is local; it's not publicly accessible.

#6 @sooskriszta
5 years ago

Ok, I have identified that ironically the issue occurs only when WordPress SEO is activated.

Please pardon the strong language, but this seems untenable. BuddyPress should provide support to popular SEO plugins, not make them less effective.

Version 0, edited 5 years ago by sooskriszta (next)

#7 follow-up: @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Page Title should show Group/Member name to wp_title filter can break BP's pages' titles

Thanks for figuring out the culprit. I've tested, and can confirm your finding. However, I don't think this is something we can properly address at the moment.

WP SEO's page title generation occurs after BuddyPress', and because WP SEO doesn't have any special treatment for BP, all the BP screens look like regular WordPress Pages to WP SEO.

We could move our wp_title function so that it runs after WP SEO's, but we'd have exactly the same problem if some other late-running plugin were to do something similar with the page title in the future.

For the benefit of anyone finding this ticket in the future, as of BP 2.1, BP uses Pages behind-the-scenes to help render its content. This has the side affect of being fragile and prone to being incompatible with other plugins that do specific things when WordPress loads a page. In the future, we'll be moving BuddyPress to using rewrite rules, which should go a long way towards smoothing out some of these difficulties (thought I suspect this particular one may remain).

#8 in reply to: ↑ 7 @sooskriszta
5 years ago

Replying to DJPaul:

because WP SEO doesn't have any special treatment for BP, all the BP screens look like regular WordPress Pages to WP SEO.

What is a good way for WPSEO to address this (in case I want to request WPSEO to treat BP pages differently)?

When I asked WPSEO about it, they said the problem is that BP doesn't register these pages as CPTs https://github.com/Yoast/wordpress-seo/issues/1400

#9 @r-a-y
5 years ago

When I asked WPSEO about it, they said the problem is that BP doesn't register these pages as CPTs

See #5801.

This ticket was mentioned in Slack in #buddypress by oc2ps. View the logs.


5 years ago

#11 @DJPaul
4 years ago

  • Component changed from Appearance - Template Pack to Appearance - Template Parts

#12 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.