Skip to:

Opened 10 years ago

Closed 10 years ago

#5786 closed defect (bug) (no action required)

Activity Search Results not Displaying comments with matching terms.

Reported by: marketraisen's profile marketraisen Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0
Component: Activity Keywords:


But the search IS finding them, they just don't appear until after the heartbeat notification for 'load newest'.

If a search result only appears in comments then no results are returned at all. When no matching activity updates are found, the heartbeat/refresh is stopped, so there is no option to load the comment search results.

Using Buddypress 2.0.1, latest wordpress, hashbuddy plugin.

Change History (3)

#1 follow-up: @DJPaul
10 years ago

imath, can you check this out sometime since you last touched this area of code? Thanks.

#2 in reply to: ↑ 1 @imath
10 years ago

Replying to DJPaul:

imath, can you check this out sometime since you last touched this area of code? Thanks.

I'm on it.

#3 @imath
10 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

hi marketraisen

Thanks for your feedback. I think it's not a BuddyPress bug but a HashBuddy one. In short: This plugin is trying to get a $_GET['hash'] var that doesn't exist in the url, it should use the $_GET['s'] one.

see my suggestion to fix the trouble here:

In details:

The plugin was trying to force the activity stream to use the display_comments => true mode when a "hash buddy" search was performed. This way comments have their 'own' activities and are not only attached to their parents and are part of the search performed by BuddyPress. The problem was: as the $_GET['hash'] doesn't exist, then the query_string is not filtered, then the mode display_comments => true is not set, then comments remain attached to their parents only, then no results because not in the scope for search.

So i'd suggest you report the problem to the plugin's author, i'm closing this ticket as invalid, but if modemlooper needs some adjustment in this area, feel free to reopen.

Note: See TracTickets for help on using tickets.