Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5780, comment 3


Ignore:
Timestamp:
07/27/2014 05:26:58 PM (6 years ago)
Author:
DJPaul
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5780, comment 3

    initial v1  
    1 `bp_edit_profile_button()` is old; one of the original xProfile functions. It was last used in BP 1.1.3 in the `bp-sn-parent` theme. Looking back at the current function and that theme, I think that it looks like the button generated by this function was intended to be used as a shortcut for site admins. Therefore I am a bit concerned about changing the `block_self` value just in case someone has painstakingly ported an original theme through all the releases since then (admittedly use an edge case).
     1`bp_edit_profile_button()` is old; one of the original xProfile functions. It was last used in BP 1.1.3 in the `bp-sn-parent` theme. Looking back at the current function and that theme, I think that it looks like the button generated by this function was intended to be used as a shortcut for site admins. Therefore I am a bit concerned about changing the `block_self` value just in case someone has painstakingly ported an original theme through all the releases since then (admittedly an edge case).
    22
    33Personally I am split between not doing anything, or as you've just blown the dust off this function, marking it as deprecated. I don't think we would recommend anyone to use it in a modern theme.