#5773 closed defect (bug) (wontfix)
group create screen input name mismatched on edit screen
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | low | |
| Severity: | minor | Version: | 2.0 |
| Component: | Groups | Keywords: | |
| Cc: | modemlooper |
Description
The group id input added on create and edit screens is off
On the edit screen:
<input type="hidden" name="group-id" id="group-id" value="142">
On the create screen:
<input type="hidden" name="group_id" id="group_id" value="142">
Notice the underscore? This causes issues when you are using the edit screen for your create screen and need to get the group id. I wrote a check in my code but shouldn't these be the same?
Change History (3)
#1
@
11 years ago
- Keywords good-first-bug added; dev-feedback removed
- Milestone changed from Awaiting Review to Future Release
#2
@
9 years ago
- Keywords good-first-bug removed
- Milestone Future Release deleted
- Resolution set to wontfix
- Status changed from new to closed
Due to the age of bp-legacy, we aren't going to make this change in BP-Legacy, but I'll check if the new template pack has the issue and report over there if so.
#3
@
9 years ago
Seems fine to me looking with Nouveau activated:
<input id="group-id" type="hidden" value="5" name="group-id">
Not sure though anything specific has been done though for new template pack or would be surprised if it had at this stage of TP however looking at bp-legacy:
<input id="group_id" type="hidden" value="6" name="group_id">
So don't see this mis-match.
It's hard to track when this was introduced due to the various themes in BuddyPress' history, but I think this goes back to at least 1.2. Being consistent on naming between the group edit/create screens is a good suggestion, and as long as the change is made in some backwards compatible manner so as to not break any existing plugins, I think this is a good idea.