Opened 9 years ago
Closed 9 years ago
#5746 closed enhancement (fixed)
using bp_group_has_members in widgets and conflicts with $_REQUEST['s']
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Groups | Keywords: | has-patch |
Cc: |
Description
Same problem reported in #5318 and fixed with null
initialization of $default_args['search_terms']
and is_null()
test before assigning $_REQUEST['s']
.
This permits to run a secondary members loop in a page (for instance in a widget) while primary loop is whatever loop (buddypress ou wordpress loop) using the search s
argument.
While the problem has been solved for the bp_has_members()
loop, it has not been solved for bp_group_has_members()
loop causing false results (even with fixing search_terms
to false
in the args array given to the loop).
This looks good. Thanks.
(One small request - in the future, please generate your patch from the root of the buddypress directory. Thanks!)