Unread message numbers do not decrement in "My Messages" optionsbar

[jeffca]

From suggestion 2 on post: http://buddypress.org/forums/topic.php?id=1217

Unread message count stays the same after message has been opened.

[apeatling]

Not important enough for 1.0, moving this to 1.1.

[(none)]

Milestone Private Messaging 1.1 deleted

[apeatling]

The count is only deprecated once the message has been opened, and is only reflected on the next page load. This will probably be fixed with AJAX, moving to 1.2.

[johnjamesjacoby]

Is it not possible to mark the message as read after we know which message it is but before the page loads and the count takes place?

[apeatling]

This patch breaks posting to a group on the activity page.

[boonebgorges]

jjj - the way things are currently set up, BP doesn't really 'know' what thread is being called up until the screen function is called up; the screen function, in turn, isn't defined until the parent item (the main Messages tab) and its name (eg Messages (2)) is already set.

Aside from completely rewriting the way that navs and subnavs register themselves, there are two strategies:
1) Reach into $bp->bp_nav and adjust the message count (after it's been registered but before it's been rendered). See 574-1.diff to see what this might look like.
2) Hook into the loading process *before* the messages nav is created with a function that checks to see (based on the action_variables etc) whether you're trying to view a single message, and if so it calls messages_mark_thread_read() on that thread.

Neither is great, but it strikes me that (1) has fewer potential problems (even though it's a bit uglier). I would rather not mess with load order if I can help it.

Thoughts?

[DJPaul]

The approach looks okay as an interim solution until bp_nav is overhauled.

[boonebgorges]

(In [4266]) Decrement unread messages count before nav is rendered when reading a private message. Fixes #574