Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#5739 closed enhancement (wontfix)

Standardization of the different parts of the sign-up form

Reported by: wcuadd's profile WCUADD Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords: needs-patch
Cc: mercijavier@…

Description

The sign up form is composed of several sections :

  • #basic-details-section
  • #profile-details-section
  • #blog-details-section

Only the xprofile fields in #profile-details-section are clearly identified with a div and a parametrised class as follows (line 69 in members/register.php in the trunk version (not 2.0.1)

<div<?php bp_field_css_class( 'editfield' ); ?>>

Note that this is very important to give the possibility to add for example a "mandatory" class to the required xprofile fields, as follows for example :

function add_mandatory_xprofile_field_class( $css_classes ) {
global $profile_template;
if ( bp_get_the_profile_field_is_required() ) $css_classes[] = ‘mandatory’;
return $css_classes;
}
add_filter( ‘bp_field_css_classes’, ‘add_mandatory_xprofile_field_class’ );

To render in a similar manner the different parts of the form, the other fields in the other sections should be caracterised equally each one with :

  1. a div
  2. and please! with a parametrised class in order to let to the developper the possibility to add his own classes. For example to add a "mandatory" class as shown above but not only, there could be other CSS rendering needs.

Change History (6)

#1 @boonebgorges
10 years ago

  • Keywords needs-patch added

I'm wary of making broad functional changes to the markup in register.php - adding additional HTML elements will have an effect on people who are using the template but overriding core CSS. That said, I think we'd be happy to see a patch that shows exactly what you have in mind.

and please! with a parametrised class in order to let to the developper the possibility to add his own classes. For example to add a "mandatory" class as shown above but not only, there could be other CSS rendering needs.

We can't simply add the bp_field_css_class() function to the other sections, because they are not technically profile fields (and don't require the xprofile component). But yes, separate functions could be written for this purpose.

#2 @mercime
10 years ago

  • Cc mercijavier@… added

#3 @DJPaul
10 years ago

  • Component changed from XProfile to Theme
  • Milestone changed from Awaiting Review to Future Release

I think the larger structure changes are something to keep in mind for whenever we eventually build new templates for BuddyPRess; agree with Boone, other than that. :)

#4 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates

#5 @DJPaul
7 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#6 @DJPaul
7 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.