messages_format_notifications(): variables not in scope

[wpdennis]

If ​messages_format_notifications() is used with any other action than "new_message", the variables $link, $filter and $text aren't declared before usage:

if ( 'string' === $format ) {
    $return = apply_filters( $filter, '<a href="' . esc_url( $link ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $text ) . '</a>', (int) $total_items, $text, $link, $item_id, $secondary_item_id );
} else {
    $return = apply_filters( $filter, array(
        'text' => $text,
        'link' => $link
    ), $link, (int) $total_items, $text, $link, $item_id, $secondary_item_id );
}

[DJPaul]

Should be an easy fix for someone looking to contribute a patch: just need to make sure these variables are declared sensibly at the top of the file.

[wolfhoundjesse]

This comment replaces the comment I wrote before I remembered that there is a place to enter a patch description. That is all.

[wolfhoundjesse]

Declarations moved to top of function.

[boonebgorges]

In 8947:

In messages_format_notifications(), declare variables early, to avoid PHP notices.

Fixes #5736

Props wolfhoundjesse