Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5733, comment 9


Ignore:
Timestamp:
10/11/2014 06:53:48 PM (6 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5733, comment 9

    initial v1  
    1 Looks okay, but instead of doing a find and replace for `'bp'` everywhere, perhaps we should create wrapper `wp_cache_X()` functions and replace all `wp_cache_X()` calls with `bp_cache_X()`.  This is so we just have to change the global cache group in one place.
     1`5733.patch` looks okay, but instead of doing a find and replace for `'bp'` everywhere, perhaps we should create wrapper `wp_cache_X()` functions and replace all `wp_cache_X()` calls with `bp_cache_X()`.  This is so we just have to change the global cache group in one place.
    22
    33The BP Multi Network plugin also reminds me of how our notification meta keys suck :)  I've got one suggestion in the plugin - why not mirror all user meta keys that `bp_update_user_meta()` calls?  Chances are that this would be useful for any plugin calling `bp_update_user_meta()`.
     4
     5----
     6
     7> The conclusion I've come to is three-fold
     8
     9> What we consider to be "global" needs an audit. (I.E. Should bp_activity_sitewide_front really be global, or is bp_activity more appropriate?)
     10
     11Some really good thoughts here.  I think we definitely need a global group solely for counts as wpdennis initially brought up.