Skip to:
Content

BuddyPress.org

Changes between Version 1 and Version 2 of Ticket #5733, comment 18


Ignore:
Timestamp:
11/02/2014 08:53:51 PM (6 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5733, comment 18

    v1 v2  
    1 As it stands today, the only component that should be using the `bp` global cache key is Members, and even it would benefit from leaning more on WordPress's core functions and global cache groups. `bp_core_get_core_userdata` is one of those functions where we are duplicating the work of `WP_User` and `update_user_caches()`. All we save by having our own user cache is skipping initializing roles and capabilities.
     1As it stands today, the only component that should be using the `bp` global cache key is Members, and even it would benefit from leaning more on WordPress's core functions and global cache groups. `bp_core_get_core_userdata` is one of those functions where we are duplicating the work of `WP_User` and `update_user_caches()`. All we save by having our own user cache is skipping initializing roles and capabilities (see #5979.)
    22
    33Every other component would benefit from a non-global, filtered cache key, so we can adjust the scope to be either global, for the network, or for the blog, based on the installation and activation.