Members directory displaying on more than one page.

[xhan]

Steps to reproduce:
Create page template, name the file page-membership-application.php

Any page using this template will load the membership directory.

Cause:
bp-core-template.php is searching for the word 'members' assumes users wont have other page templates with the word members in it.

line 1114

if ( !empty( $page_template ) && strstr( strtolower( $page_template ), strtolower( $component ) ) ) {

I've not tested this too thoroughly as I haven't had time so for now I've just renamed my template page-mem-application.php

[boonebgorges]

Moving to 2.1 for a further look. Using strstr() in this way seems really odd to me, so someone should have a look to see why this check was introduced in the first place. (It could be a legacy concern that's no longer relevant.)

[DJPaul]

Confirmed.

[DJPaul]

Dates way back to r3884: "to look for page templates as root_slug's too".

@JJJ: can you take a look at this please?

[DJPaul]

Let's pull out strstr early in 2.2 to give us time to see if we can re-discover the edge case, or if JJJ can remember any more details why this change was made.

[pro120]

Remove page template fallback check

[pro120]

Looks like this was most likely a legacy concern that is improperly matching standard page templates.

[johnjamesjacoby]

Patch looks good. It fixes both the original bug, and another redirect issue related to more recent changes to theme compatibility template handling.

[johnjamesjacoby]

In 9091:

Remove page template name check in bp_is_current_component() introduced in r3884, fixing potential collisions causing unexpected template output or redirections.

Props pro120. Fixes #5721.