Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 8 years ago

#5679 closed enhancement (wontfix)

Harmonize jQuery search term fetching in bp-legacy/buddypress.js

Reported by: dcavins's profile dcavins Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Templates Keywords: has-patch early
Cc:

Description

When switching scope tabs, fetch the search_terms using the same method as other portions of buddypress.js. This is helpful for instance when working with BP Group Hierarchy, which declares the object to be 'tree' for the groups directory.

Similarly, I'd like to add a fallback for the "order by filter" that will fetch the order by parameter without relying on the object. I left the old method intact for backwards compatibility. (I'd really prefer to add a class "orderby" to that li in addition to "filter" and use that as the selector, but then it would require a template update, too...)

Thanks!

Attachments (1)

search_term_fetching.patch (764 bytes) - added by dcavins 10 years ago.

Download all attachments as: .zip

Change History (10)

#1 @DJPaul
10 years ago

  • Milestone changed from Awaiting Review to 2.1

This ticket was mentioned in IRC in #buddypress-dev by paulgibbs. View the logs.


10 years ago

#3 @DJPaul
10 years ago

  • Keywords early added
  • Milestone changed from 2.1 to 2.2

Sorry that we ran out of time for this ticket, as well.

#4 @DJPaul
10 years ago

  • Milestone changed from 2.2 to Future Release

*doesn't have any excuses this time*

#5 @DJPaul
9 years ago

  • Component changed from Appearance - Template Pack to Appearance - Template Parts

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates

#7 @DJPaul
8 years ago

@dcavins if you still want this in, can you test and commit? Otherwise, close the ticket.

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


8 years ago

#9 @dcavins
8 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I'm closing this because it really only applies to bp-legacy, which is not long for this world (we hope). :)

Note: See TracTickets for help on using tickets.