Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5676 closed enhancement (no action required)

Safe Class for custom filter items in .item-list-tabs

Reported by: dcavins's profile dcavins Owned by:
Milestone: Priority: normal
Severity: minor Version: 2.0
Component: Core Keywords: has-patch reporter-feedback
Cc: david.cavins@…

Description

When adding filters, etc, in #subnav.item-list-tabs on the groups directory, the filter that I think is intended for the main navigation (All Groups/My Groups) is also fired for the subnav list items. A dev could use the class "last" (it has been specifically excluded from the jQuery function) but that includes presentation, too. This patch adds a non-presentational class that tells BP to take it easy.

Attachments (1)

bp-ajax-ignore-class.patch​ (629 bytes) - added by dcavins 10 years ago.

Download all attachments as: .zip

Change History (7)

@dcavins
10 years ago

#1 @dcavins
10 years ago

  • Cc david.cavins@… added

#2 @DJPaul
10 years ago

  • Milestone changed from Awaiting Review to 2.1

Need to look into this but if it behaves how you says it does, patch looks ok. :)

This ticket was mentioned in IRC in #buddypress-dev by paulgibbs. ​View the logs.
10 years ago

#4 @DJPaul
10 years ago

  • Keywords early added
  • Milestone changed from 2.1 to 2.2

We ran out of time to dive into this one, too. Sorry dcavins

#5 follow-up: @r-a-y
10 years ago

  • Keywords reporter-feedback added; early removed

dcavins - Wouldn't it be possible to use the no-ajax CSS class for this?

#6 in reply to: ↑ 5 @dcavins
10 years ago

  • Milestone 2.2 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Replying to r-a-y:

dcavins - Wouldn't it be possible to use the no-ajax CSS class for this?

I think you're right:
​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/js/buddypress.js#L836

I'll close this ticket until I have a chance to double-check it.

Note: See TracTickets for help on using tickets.