Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5663 closed defect (bug) (fixed)

Activity Administration screen notice in display method

Reported by: imath's profile imath Owned by: djpaul's profile djpaul
Milestone: 2.1 Priority: normal
Severity: normal Version: 1.6
Component: Activity Keywords: has-patch 2nd-opinion
Cc:

Description

"Indirect modification of overloaded property BP_Activity_List_Table::$_args has no effect"

I wonder what is the goal of what's causing this notice on line 1141 :
extract( $this->_args );

I don't see any use of the extracted vars in BP_Activity_List_Table->display().

I suggest to simply remove this line.

Attachments (2)

5663.diff (500 bytes) - added by imath 10 years ago.
5663.02.patch (803 bytes) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (5)

@imath
10 years ago

#1 @imath
10 years ago

  • Component changed from Core to Activity
  • Version set to 1.6

@imath
10 years ago

#2 @imath
10 years ago

Just noticed the group administration screen was also displaying a notice, reason why i've added 5663.02.patch

#3 @djpaul
10 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 8485:

Admin screens: remove redundant extract() calls.

Removes PHP warnings about indirect modification of overloaded properties..

Fixes #5663, props imath.

Note: See TracTickets for help on using tickets.