Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5620 closed enhancement (fixed)

Travis CI: Including PHP 5.6 beta in test matrix

Reported by: netweb's profile netweb Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: Core Keywords:
Cc:

Description

via ticket:5160#comment:49

5160-php56.diff / PHP 5.6

  • Do you have any context for this change?
  • If the tests are failing on 5.6, why? Aren't those bugs we need to fix? ;)

If the tests are failing then indeed these should be fixed. That said PHP 5.6 is still 'beta' and a flexible, not rigid, test resulst for PHP 5.6 should not reflect the pass/fail Travis CI build status of BuddyPress.

In the attached patch I updated it for testing WordPress /trunk

It could be easily set also include 3.7.x, 3.8.x, 3.9.x and /trunk within the allow_failures section of the config.

Travis CI docs here ​http://docs.travis-ci.com/user/build-configuration/#Rows-That-are-Allowed-To-Fail

You can also define rows that are allowed to fail in the build matrix. Allowed failures are items in your build matrix that are allowed to fail without causing the entire build to be shown as failed. This lets you add in experimental and preparatory builds to test against versions or configurations that you are not ready to officially support.

Attachments (1)

5160-php56.diff​ (500 bytes) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (2)

@netweb
10 years ago

#1 @johnjamesjacoby
10 years ago

  • Milestone changed from Awaiting Review to 2.1
  • Resolution set to fixed
  • Status changed from new to closed

In 8392:

Update .travis.yml to play nicer with PHP5.6. We can revisit this when 5.6 is considered stable. Props netweb. Fixes #5620.

Note: See TracTickets for help on using tickets.