Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

#5561 closed defect (bug) (fixed)

Adjust layouts of two-column info in Welcome Screen

Reported by: mercime's profile mercime Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch needs-testing
Cc:

Description

Correct layout of featured items in welcome screen which went awry when upgrading to WP 3.9.

  • The first patch fixes the layout.
  • The second patch fixes the layout using new styles found in WP 3.9 welcome screen and removes the inline style used on featured images.

Attachments (7)

5561.patch (1.1 KB) - added by mercime 11 years ago.
First patch fixes the layout.
5561-2.patch (3.5 KB) - added by mercime 11 years ago.
The second patch fixes the layout using new styles found in WP 3.9 welcome screen and removes the inline style used on featured images.
welcome-screen-change.png (491.0 KB) - added by mercime 11 years ago.
Broken layout as seen in Chrome and Firefox
2014-04-18 09-51-33.png (361.3 KB) - added by r-a-y 11 years ago.
Attached screenshot is 5561-2.patch on WP 3.8.3 (Firefox). Looks a little tight.
5561-3.patch (3.6 KB) - added by mercime 11 years ago.
Third patch built on second patch brings back inline style to image at 95%
5561-3-WP383.png (99.0 KB) - added by mercime 11 years ago.
Third patch on WP 3.8.3
5561-3-WP39.png (93.6 KB) - added by mercime 11 years ago.
Third patch on WP 3.9

Download all attachments as: .zip

Change History (14)

@mercime
11 years ago

First patch fixes the layout.

@mercime
11 years ago

The second patch fixes the layout using new styles found in WP 3.9 welcome screen and removes the inline style used on featured images.

@mercime
11 years ago

Broken layout as seen in Chrome and Firefox

#1 @boonebgorges
11 years ago

  • Component changed from Core to Administration
  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 2.0.1

I'd like to make sure this looks decent in at least 3.8 as well.

@r-a-y
11 years ago

Attached screenshot is 5561-2.patch on WP 3.8.3 (Firefox). Looks a little tight.

#2 @r-a-y
11 years ago

I don't think this is a dealbreaker though.

#3 @boonebgorges
11 years ago

I don't think this is a dealbreaker though.

Nah, that's good enough, especially if it'd take more than a minute to clean it up. Just want to make sure it's not totally haywire.

@mercime
11 years ago

Third patch built on second patch brings back inline style to image at 95%

@mercime
11 years ago

Third patch on WP 3.8.3

@mercime
11 years ago

Third patch on WP 3.9

#4 @mercime
11 years ago

Just a note that if we use the first patch, the layout rendered will exactly be the same for users on WP 3.8.3 or WP 3.9

#5 @DJPaul
11 years ago

To clarify: 5561-3.patch is the contender to be committed, right?

#6 @mercime
11 years ago

It can be either 5561.patch or 5561-3.patch, lead dev's choice.
Personally, I like the first patch as layout looks the same in WP 3.8.3 and WP 3.9.

#7 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 8334:

Improve layout of Welcome screen, for greater consistency across browsers and WP versions

Fixes #5561

Props mercime

Note: See TracTickets for help on using tickets.