Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 5 years ago

Last modified 3 years ago

#5548 closed enhancement (fixed)

Support native (browser or device) camera for avatar upload

Reported by: boonebgorges Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-patch
Cc:

Description

We support uploading images for avatars, so we may as well support taking a new picture too. getUserMedia() should allow us to do this fairly seamlessly. imath has a plugin that implements it: https://github.com/imath/buddybooth So much of the hard work is done. We'd just need a code and UX review.

Attachments (1)

5548.patch (20.1 KB) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (14)

#1 follow-up: @DJPaul
6 years ago

Cool idea, but I don't think we should bundle any SWFs with BuddyPress. Generally, we don't have access a Flash file's source code (did imath write the one in his plugin, or did he get it from somewhere else?), and even if we did, we don't have sufficient expertise with understanding if that Flash code is well written and secure. Instead, if a user isn't using a device that offers camera support, we just don't show those controls on the screen.

#2 @boonebgorges
6 years ago

Good points, DJPaul. Bailing if we don't have native support is what I had in mind.

#3 in reply to: ↑ 1 @imath
6 years ago

Replying to DJPaul:

did imath write the one in his plugin, or did he get it from somewhere else?

i've written it, knowing a bit of actionscript. But i agree we should simply bail if getUserMedia() is not supported by the browser.

#4 @imath
6 years ago

  • Component changed from Core to Avatars
  • Keywords has-patch added

5548.patch is a first attempt. I think it needs some improvements because so far i'm forcing 150x150 pixels for avatar and some sites/themes might use custom sizes thanks to filters bp_core_avatar_full_height and bp_core_avatar_full_width. I need to explore a bit more how to deal with that possibility & drawImage function.

here's a screenshot with my face! (sorry 4 that ;) )
https://farm4.staticflickr.com/3829/14327035543_d3b882b9da_z.jpg

@imath
6 years ago

#5 follow-up: @boonebgorges
6 years ago

This looks like an awesome start! Can't wait to dig in a little more.

I need to explore a bit more how to deal with that possibility & drawImage function.

Include these values in wp_localize_script().

#6 in reply to: ↑ 5 @imath
6 years ago

Replying to boonebgorges:

This looks like an awesome start! Can't wait to dig in a little more.

Thanks :)

Include these values in wp_localize_script().

Yeah, thought of it, the problem i'll have to deal with is video width & aspect ratio i think

This ticket was mentioned in IRC in #buddypress-dev by paulgibbs. View the logs.


5 years ago

#8 @DJPaul
5 years ago

  • Keywords early needs-patch added; has-patch removed
  • Milestone changed from 2.1 to 2.2

I get the feeling this is close, but needs some more iteration and testing. It would be great to overhaul this along with some other avatar-related things, so moving to 2.2.

#10 @DJPaul
5 years ago

  • Keywords early removed
  • Milestone changed from 2.2 to Future Release

#11 @imath
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in #6290

#12 @DJPaul
5 years ago

  • Milestone changed from Future Release to 2.3

#13 @DJPaul
3 years ago

  • Component changed from API - Avatars to Media
Note: See TracTickets for help on using tickets.