Support native (browser or device) camera for avatar upload

[boonebgorges]

We support uploading images for avatars, so we may as well support taking a new picture too. getUserMedia() should allow us to do this fairly seamlessly. imath has a plugin that implements it: ​https://github.com/imath/buddybooth So much of the hard work is done. We'd just need a code and UX review.

[DJPaul]

Cool idea, but I don't think we should bundle any SWFs with BuddyPress. Generally, we don't have access a Flash file's source code (did imath write the one in his plugin, or did he get it from somewhere else?), and even if we did, we don't have sufficient expertise with understanding if that Flash code is well written and secure. Instead, if a user isn't using a device that offers camera support, we just don't show those controls on the screen.

[boonebgorges]

Good points, DJPaul. Bailing if we don't have native support is what I had in mind.

[imath]

Replying to DJPaul:

did imath write the one in his plugin, or did he get it from somewhere else?

i've written it, knowing a bit of actionscript. But i agree we should simply bail if getUserMedia() is not supported by the browser.

[imath]

5548.patch is a first attempt. I think it needs some improvements because so far i'm forcing 150x150 pixels for avatar and some sites/themes might use custom sizes thanks to filters bp_core_avatar_full_height and bp_core_avatar_full_width. I need to explore a bit more how to deal with that possibility & drawImage function.

here's a screenshot with my face! (sorry 4 that ;) )

[boonebgorges]

This looks like an awesome start! Can't wait to dig in a little more.

I need to explore a bit more how to deal with that possibility & drawImage function.

Include these values in wp_localize_script().

[imath]

Replying to boonebgorges:

This looks like an awesome start! Can't wait to dig in a little more.

Thanks :)

Include these values in wp_localize_script().

Yeah, thought of it, the problem i'll have to deal with is video width & aspect ratio i think

[DJPaul]

I get the feeling this is close, but needs some more iteration and testing. It would be great to overhaul this along with some other avatar-related things, so moving to 2.2.

[sooskriszta]

Related ​https://buddypress.trac.wordpress.org/ticket/4132#comment:43

[imath]

Fixed in #6290