Skip to:

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#5541 closed enhancement (no action required)

Notifications on new message

Reported by: sgr33n's profile SGr33n Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Messages Keywords: reporter-feedback 2nd-opinion



I'm just figuring out that when you recive a private message you have two notifications, the one in "Notifications" and the other in "Messages". Would be enough to have just the one in "Messages"?

Attachments (1)

notifications.png (159.0 KB) - added by SGr33n 10 years ago.

Download all attachments as: .zip

Change History (7)

#1 @imath
10 years ago

  • Component changed from Core to Messaging
  • Keywords reporter-feedback 2nd-opinion added

Hi SGr33n

Correct me if i'm wrong, but i think this is 2 separate things :

  • You have 1 notification in the "notification center" (WP Admin Bar) and as a result in the user's notification not read screen
  • You have an indication in the messages list that a message is not read.

If you remove one of these two things, i think it's a bit embarassing. If you remove the screen notification, there can be users that set their email settings to not receive an email when a private message is sent. Then unless these users go into their private message inbox, they won't know a private message is not read.
If you remove the indication, then going into the inbox, it's hard to figure out what message is not read.

So IMO, we should keep both.

10 years ago

#2 @SGr33n
10 years ago

Hi imath!

I supposed that the indication in the private messages list was enough... that rounded counter appears as a notification itself... then going into the inbox folder the appropriate css styling is already indicating you which message is not read yet, there is also another rounded counter before the conversation.

I will attach a capture. There are two red rounded counters meaning the same advice. This is my work in progress theme, but in this part is similar to the base buddypress theme.

#3 @imath
10 years ago

Thanks for your feedback, I think it's a theme concern. You're paying more attention to it because your theme is including 2 bubbles in the WP Admin Bar. This actually happens with every components, for instance, in case of a mention:

You're not paying attention because there's no specific mention bubble in the WP Admin Bar, but if you detail the menu, you'll see there's a bubble for Notifications and Mentions.

I think in your specific case, the theme's functions.php or a bp-custom.php could neutralize the notifications for the private message component. Everything is available in core to do so. For instance you could have this line in one of the files :

function remove_messages_sent_notification() {
	remove_action( 'messages_message_sent', 'bp_messages_message_sent_add_notification', 10 );
add_action( 'bp_init', 'remove_messages_sent_notification' );

Finally, IMO, we shouldn't change this behavior in core, but a theme or better a utility plugin could do so using the remove action code

Last edited 10 years ago by imath (previous) (diff)

#4 follow-up: @SGr33n
10 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Infact, you're right,

Thanks for your support imath :)

Last edited 10 years ago by SGr33n (previous) (diff)

#5 in reply to: ↑ 4 @imath
10 years ago

Replying to SGr33n:

Infact, you're right,

Thanks for your support imath :)

You're welcome :) Just updated the remove action trick in my previous comment because i've noticed it would work better by including it earlier in BuddyPress load process ( by adding an action to 'bp_init' for instance )

#6 @SGr33n
10 years ago

Perfect :)
Thanks again!

Note: See TracTickets for help on using tickets.