Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#553 closed defect (bug) (fixed)

bp-core-widgets - handling of empty settings

Reported by: djpaul's profile DJPaul Owned by:
Milestone: Priority: minor
Severity: Version: 1.0
Component: Keywords:
Cc: djpaul@…

Description

I have tested this using the standard Welcome widget, but I think it will equally apply to the other standard widgets. This may apply to the "body text" as well as the "title" settings for each widget but I have only tested with the title for the Welcome widget.

The Welcome widget in the Admin -> Widgets control panel sets the title and body text of the Welcome widget, however it allows a blank title.
The HTML output looks like this: <h3><?php echo $optionstitle? ?></h3>

The control panel allows the Title to be set to no value, ergo you get <h3></h3> rendered. Either the values for the widgets need to both mandatory, or a check added on the output to see if the variable is non-blank. I suggest the latter.

Change History (2)

#1 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1198]) Fixes #553

#2 @(none)
15 years ago

  • Milestone Core 1.0 deleted

Milestone Core 1.0 deleted

Note: See TracTickets for help on using tickets.