Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#5528 closed defect (bug) (fixed)

Javascript error on Activity stream.

Reported by: pross's profile pross Owned by: imath's profile imath
Milestone: 2.0 Priority: normal
Severity: normal Version: 2.0
Component: Activity Keywords: has-patch
Cc:

Description

Using latest beta and trunk on a fresh install using 2014 theme.

If there is no activity already posted you get the following error when you click submit.

Uncaught TypeError: Cannot call method 'match' of undefined

Included patch fixes the error.

Attachments (1)

activity.patch​ (781 bytes) - added by pross 10 years ago.

Download all attachments as: .zip

Change History (5)

@pross
10 years ago

#1 @imath
10 years ago

  • Milestone changed from Awaiting Review to 2.0

Nice catch @pross

#2 @imath
10 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 8264:

When posting the very first activity update, avoid checking for previous activities

Since r8251, Activity HeartBeat feature needs to "parse" the different classes of the first activity item displayed in the stream. But before doing so, we actually need to check there is at least one activity displayed.

props pross

Fixes #5528

#3 follow-up: @r-a-y
10 years ago

I know this is a little late, but perhaps instead of using the CSS class to look for new activities, we should use HTML5's data- attribute. (eg. data-activity-recorded="...").

Maybe in 2.1?

#4 in reply to: ↑ 3 @imath
10 years ago

Replying to r-a-y:

I know this is a little late, but perhaps instead of using the CSS class to look for new activities, we should use HTML5's data- attribute. (eg. data-activity-recorded="...").

Maybe in 2.1?

I wrongly thought about backcompat with theme, but as it's not available in BP Default, i guess you're right ;)

Note: See TracTickets for help on using tickets.