Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 6 years ago

#5491 closed enhancement (maybelater)

Improve error message phrasing and plurals on group admin panels

Reported by: danbp's profile danbp Owned by:
Milestone: Priority: normal
Severity: minor Version: 1.8
Component: Groups Keywords: needs-patch, trac-tidy-2018
Cc:

Description

BP 2.0 beta testing with WP 3.8.1 and 2012 theme - local install with php 5.4.12 - mySql 5.6.12 - apache 2.2.4

bp-groups-admin.php:477
Fonctionnality here is to add/remove members from a group. This phrase is not correct:
The following members were successfully modified: <em>%s</em>
Logically this should be:
The following members were successfully removed from this group: <em>%s</em>
Aside, this string needs a plural form. You can remove one OR more members from a group.

Change History (5)

#1 @boonebgorges
10 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.0 to 2.1
  • Severity changed from normal to minor
  • Summary changed from Wrong phrase and missing plural form to Improve error message phrasing and plurals on group admin panels
  • Type changed from defect (bug) to enhancement
  • Version set to 1.8

It'll take some rewriting to differentiate between different kinds of user modifications (removals vs promotions vs adds vs bans). Not sure it's worth the effort, though patches are certainly welcome.

As for the singular/plural bit, I'm pretty sure I did this on purpose. "The following members: Boone" is not very elegant, but (at least in English) it doesn't strike me as outright incorrect. That said, it's not terribly difficult to rewrite these success/error messages for singular/plural distinctions. We can do that for 2.1.

Both of these issues have been present since the introduction of the groups admin panels, so this does not need to be fixed for 2.0.

#2 @DJPaul
10 years ago

  • Milestone changed from 2.1 to 2.2

#3 @DJPaul
10 years ago

  • Milestone changed from 2.2 to Future Release

#4 @DJPaul
6 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#5 @DJPaul
6 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.