Symlinked 'buddypress' directory not referenced when setting buddypress()->file

[r-a-y]

If we are manually defining the BP_PLUGIN_DIR constant for symlinking purposes, buddypress()->file does not take this into consideration.

This notably breaks the bp_is_network_activated() function because buddypress()->basename references __FILE__ instead of the symlinked directory.

To test:

• Set up a new multisite install with the 'buddypress' directory symlinked.
• Network-activate BuddyPress and go to the network admin dashboard
• You won't see the following items: "Settings > BuddyPress", "Tools > BuddyPress"

Attached patch addresses this by setting buddypress()->file to use the BP_PLUGIN_DIR constant.

[boonebgorges]

I've experienced this exact problem before.

r-a-y, I think that your patch looks like the right solution, but in an abundance of caution (and since this is not a regression in 2.0), I'd prefer to do it for 2.1. Is that OK with you?

[DJPaul]

Do the plugins directory symlink changes in WP 3.9 affect this at all?

[r-a-y]

Do the plugins directory symlink changes in WP 3.9 affect this at all?

Since __FILE__ is PHP-specific, WP 3.9 will not affect this ticket. When symlinked, __FILE__ references the original file.

[DJPaul]

r-a-y can this be closed in favour of #5652 ?

[r-a-y]

can this be closed in favour of #5652 ?

I'd say so. Closing!