Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#5467 closed enhancement (fixed)

Replace .parent() for .closest in buddypress.js

Reported by: hnla Owned by: boonebgorges
Priority: normal Milestone: 2.0
Component: Templates Version:
Severity: normal Keywords: has-patch
Cc:

Description

In the same manner of previous tickets on this aspect another .parent().parent().parent() has caused issues with adjusted markup causing activity unfav in activity favourit view jumping it's slideUp() to the wrong parent node and hiding all the activity items rather than the activity-item in question.

Patch replaces .parent() with .closest('activity-item')

Attachments (2)

5467.patch​ (484 bytes ) - added by hnla 13 years ago.
change .parent() to .closest() for activity unfav
5467.2.patch​ (485 bytes ) - added by hnla 13 years ago.

Download all attachments as: .zip

Change History (5)

@hnla
13 years ago

change .parent() to .closest() for activity unfav

@hnla
13 years ago

#1 @boonebgorges
13 years ago

  • Milestone Awaiting Review → 2.0

#2 @boonebgorges
13 years ago

  • Owner set to boonebgorges
  • Resolution → fixed
  • Status new → closed

In 8138:

Use closest() instead of parent() to hide unfavorited activity item

Ancestor-crawling makes for inflexible javascript, which makes for sad developers.

Fixes #5467

Props hnla

#3 @DJPaul
10 years ago

  • Component Appearance - Template Parts → Templates
Note: See TracTickets for help on using tickets.