Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 3 years ago

#5462 closed enhancement (maybelater)

Heartbeat API to loaded activities and comments

Reported by: mpa4hu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: trac-tidy-2018
Cc:

Description

https://buddypress.trac.wordpress.org/ticket/5328

What about comments, I think instead of sending last ID, buddypress can send parent activities that are loaded. Then check if any new activity (with comments argument: stream) so get every activity on client side and loop over them. if this is parent, just append it, else if it is a comment append to its parent.

So how this works in my mind )

1) When loaded buddypress can save data attribute on #activity-stream
<div id="activity-stream" data-activities-loaded="2,4,5,7"></div>

2) send heartbeat with this data attribute

3) if (bp_has_activities( bp_ajax_querystring( 'activity' ) . '&display_comments=stream' ))

4) when received:

if($(this).hasClass('activity_comment') {

append to its parent

} else {

append to #activity-stream

}

5) update activities-loaded attribute

(data-activities should also be updated when load_more_activity happens.

Maybe this adds a little overhead but definitely would improve user experience.

Change History (6)

#1 @mpa4hu
7 years ago

Okay didn't really explained why to send loaded activities:

on server side check if this is comment and comment parent is loaded. if its not loaded, there is no need to send this activity back to client.

#2 @imath
7 years ago

  • Milestone changed from Awaiting Review to 2.1

Hi mpa4hu,

Thanks for your feedback, Activity HeartBeat checking will be available in 2.0. I think we should first check how users are welcoming this new feature before enhancing it. I propose to be back on this ticket later.

#3 @DJPaul
7 years ago

  • Milestone changed from 2.1 to 2.2

#4 @DJPaul
6 years ago

  • Milestone changed from 2.2 to Future Release

#5 @DJPaul
3 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#6 @DJPaul
3 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.